p-sw/pswui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(cli): change onSubmit typing in SearchBox

Browse Source 
The onSubmit function typing in the SearchBox component was changed from handling a string to handling a generic T type object. Also, the onSubmit function now uses the found item in components based on the selected suggestion to submit instead of submitting directly.
This commit is contained in:
p-sw 2024-06-08 02:51:27 +09:00
parent 62e606f273
commit 12b1d530c4
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
packages/cli/src/components/SearchBox.tsx
View File

@ -17,7 +17,7 @@ export function SearchBox<T extends {key: string; displayName: string}>({
initialQuery?: string initialQuery?: string
onKeyDown?: (i: string, k: Key, app: ReturnType<typeof useApp>) => void onKeyDown?: (i: string, k: Key, app: ReturnType<typeof useApp>) => void
onChange?: (item: T) => void onChange?: (item: T) => void
onSubmit?: (value: string) => void onSubmit?: (item: T) => void
}) { }) {
const [query, setQuery] = useState<string>(initialQuery ?? '') const [query, setQuery] = useState<string>(initialQuery ?? '')
const [queryMode, setQueryMode] = useState<boolean>(true) const [queryMode, setQueryMode] = useState<boolean>(true)
@ -79,7 +79,10 @@ export function SearchBox<T extends {key: string; displayName: string}>({
}} }}
showCursor showCursor
placeholder={' query'} placeholder={' query'}
onSubmit={onSubmit} onSubmit={() => {
const found = components.find(({key}) => key === suggestions[selected])
found && onSubmit?.(found)
}}
/> />
</Box> </Box>
<Divider title={isLoading ? 'Loading...' : `${suggestions.length} components found.`} /> <Divider title={isLoading ? 'Loading...' : `${suggestions.length} components found.`} />