p-sw/pswui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(cli): normalize component name input

Browse Source 
This change includes normalization of user input for component name by converting it to lowercase during the installation process. This is done to ensure that component names are not case sensitive and that any input will match the existing component names in the registry.
This commit is contained in:
p-sw 2024-06-07 19:00:50 +09:00
parent 610979f9fa
commit 91d9b9f9f3
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
packages/cli/src/commands/add.ts
View File

@ -31,6 +31,8 @@ export default class Add extends Command {
this.error('No component name provided. Please provide name of component you want to be installed.') this.error('No component name provided. Please provide name of component you want to be installed.')
} }
const name = args.name.toLowerCase()
const resolvedConfig = await validateConfig((message: string) => this.log(message), await loadConfig(flags.config)) const resolvedConfig = await validateConfig((message: string) => this.log(message), await loadConfig(flags.config))
const componentFolder = join(process.cwd(), resolvedConfig.paths.components) const componentFolder = join(process.cwd(), resolvedConfig.paths.components)
const sharedFile = join(process.cwd(), resolvedConfig.paths.shared) const sharedFile = join(process.cwd(), resolvedConfig.paths.shared)
@ -49,8 +51,8 @@ export default class Add extends Command {
const componentNames = await getAvailableComponentNames(registry) const componentNames = await getAvailableComponentNames(registry)
loadRegistryOra.succeed(`Successfully fetched registry! (${componentNames.length} components)`) loadRegistryOra.succeed(`Successfully fetched registry! (${componentNames.length} components)`)
if (!componentNames.includes(args.name)) { if (!componentNames.includes(name)) {
this.error(`Component with name ${args.name} does not exists in registry. Please provide correct name.`) this.error(`Component with name ${name} does not exists in registry. Please provide correct name.`)
} }
const sharedFileOra = ora('Installing shared module...').start() const sharedFileOra = ora('Installing shared module...').start()
@ -69,12 +71,12 @@ export default class Add extends Command {
sharedFileOra.succeed('Shared module is already installed!') sharedFileOra.succeed('Shared module is already installed!')
} }
const componentFileOra = ora(`Installing ${args.name} component...`).start() const componentFileOra = ora(`Installing ${name} component...`).start()
const componentFile = join(componentFolder, registry.components[args.name]) const componentFile = join(componentFolder, registry.components[name])
if (existsSync(componentFile) && !flags.force) { if (existsSync(componentFile) && !flags.force) {
componentFileOra.succeed(`Component is already installed! (${componentFile})`) componentFileOra.succeed(`Component is already installed! (${componentFile})`)
} else { } else {
const componentFileContentResponse = await fetch(await getComponentURL(registry, args.name)) const componentFileContentResponse = await fetch(await getComponentURL(registry, name))
if (!componentFileContentResponse.ok) { if (!componentFileContentResponse.ok) {
componentFileOra.fail( componentFileOra.fail(
`Error while fetching component file content: ${componentFileContentResponse.status} ${componentFileContentResponse.statusText}`, `Error while fetching component file content: ${componentFileContentResponse.status} ${componentFileContentResponse.statusText}`,