From fc4e11f5f9baebf4cbcde0b832a3dd54ec22e268 Mon Sep 17 00:00:00 2001
From: p-sw <shinwoo.park@psw.kr>
Date: Mon, 3 Jun 2024 22:08:42 +0900
Subject: [PATCH] fix: make Tab return null instead of using hidden class

---
 packages/react/components/Tabs.tsx | 35 +++++++++++++-----------------
 1 file changed, 15 insertions(+), 20 deletions(-)

diff --git a/packages/react/components/Tabs.tsx b/packages/react/components/Tabs.tsx
index 8a73454..a54f2fd 100644
--- a/packages/react/components/Tabs.tsx
+++ b/packages/react/components/Tabs.tsx
@@ -194,19 +194,11 @@ const TabTrigger = (props: TabTriggerProps) => {
 
 const [tabContentVariant, resolveTabContentVariantProps] = vcn({
   base: "",
-  variants: {
-    active: {
-      true: "",
-      false: "hidden",
-    },
-  },
-  defaults: {
-    active: false,
-  },
+  variants: {},
+  defaults: {},
 });
 
-interface TabContentProps
-  extends Omit<VariantProps<typeof tabContentVariant>, "active"> {
+interface TabContentProps extends VariantProps<typeof tabContentVariant> {
   name: string;
   children: Exclude<
     React.ReactNode,
@@ -220,15 +212,18 @@ const TabContent = (props: TabContentProps) => {
   const { name, ...restProps } = restPropsBeforeParse;
   const [context] = React.useContext(TabContext);
 
-  return (
-    <Slot
-      className={tabContentVariant({
-        ...variantProps,
-        active: context.active[1] === name,
-      })}
-      {...restProps}
-    />
-  );
+  if (context.active[1] === name) {
+    return (
+      <Slot
+        className={tabContentVariant({
+          ...variantProps,
+        })}
+        {...restProps}
+      />
+    );
+  } else {
+    return null;
+  }
 };
 
 export { TabProvider, useTabState, TabList, TabTrigger, TabContent };